search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 38 forks source link

Warns when dependencies are not installed #29

Closed marcioj closed 9 years ago

marcioj commented 9 years ago

Does make sense to ember-cli-dependency-checker warns when node_modules or bower_components are not present? For instance running some ember-cli command in a project without node_modules will throw Error: Cannot find module 'ember-cli/lib/broccoli/ember-app'. I think we could show a better message like: No dependencies installed. Runnpm installandbower installto install missing dependencies.

This is related to ember-cli/ember-cli#3961, but I think this kind of check belongs here.

Thoughts?

//cc @stefanpenner @quaertym

stefanpenner commented 9 years ago

I think we could show a better message like: No dependencies installed. Run npm install and bower install to install missing dependencies.

+1 better error message

quaertym commented 9 years ago

:+1: from me

marcioj commented 9 years ago

Looks like the ember-cli-dependency-checker isn't a direct dependency from ember-cli, actually it's a dependency from generated apps. So add this verification here won't work because if we're able to run dependency-checker that means that node_modules are already installed. Sorry for the confusion :smile:

quaertym commented 9 years ago

:smile: Yep, we totally forgot that.