search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

Use ember-cli project `nodeModulesPath` when available #31

Closed bantic closed 9 years ago

bantic commented 9 years ago

This is a follow-up PR as mentioned in PR 26.

https://github.com/ember-cli/ember-cli/pull/3771 has added a nodeModulesPath property to the ember-cli project. This PR detects and uses that property if it is available, which will allow ember-cli-dependency-checker to function properly for ember-cli projects that have a node_modules directory outside of the project root.

This also adds a projectBuilder test helper to unify the set up of a sample project in tests.

rwjblue commented 9 years ago

:+1:

mixonic commented 9 years ago

@quaertym I know the powers that be are swinging for an ember-cli release this week. I'd love to see this go with it if you have the time to review.

quaertym commented 9 years ago

It looks great, thanks! :beer:

mixonic commented 9 years ago

Awwww sweet :-) Are you going to roll a release as well? You are about to make my week.

quaertym commented 9 years ago

Yep, it is coming. :+1:

mixonic commented 9 years ago

:heart_eyes: