search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

transition away from SKIP_DEPENDENCY_CHECKER for linked projects #38

Closed stefanpenner closed 9 years ago

stefanpenner commented 9 years ago

overall the dependency checking is extremely valuable, except when developing a module via npm link.

Using SKIP_DEPENDENCY_CHECKER=true in this scenario is actually an anti-pattern, as it is insufficiently granular.

Let me propose instead, npm link'ed modules that do not satisfy the version contraints by default merely warn.

note: https://github.com/quaertym/ember-cli-dependency-checker/blob/master/lib/dependency-checker.js#L31

cc @rwjblue

quaertym commented 9 years ago

@stefanpenner How can I detect linked modules?

stefanpenner commented 9 years ago

if they symlinked i think

rwjblue commented 9 years ago

This seems fine with me. But I do not want to have the env flag removed as it provides a handy escape hatch for some scenarios.

stefanpenner commented 9 years ago

@rwjblue yes, it can stay. It will though reduce the number of scenarios where we need it.