search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 38 forks source link

Option to error out when missing dependencies found #4

Closed patocallaghan closed 10 years ago

patocallaghan commented 10 years ago

Thanks for this addon. I've been needing something like this for a while now. Any chance an option be added to error out of the command if missing dependencies are detected?

The application shouldn't work anyway so I think this would be reasonable.

quaertym commented 10 years ago

Thanks for the feedback :+1: . I will discuss this with ember-cli collaborators after I fix some other more critical issues.

rwjblue commented 10 years ago

Should be able to throw an error that has suppressStacktrace when validation fails. The message should be something very actionable (like the specific versions that are missing or the invalid version that is being used).

For an example take a look at ember-cli's SilentError: https://github.com/stefanpenner/ember-cli/blob/master/lib/errors/silent.js.

quaertym commented 10 years ago

Fixed by 4acec89ee8e9e6dc7f7a7d2b7353e79a08942e21. Available in v0.0.4.