Closed trabus closed 8 years ago
I am not opposed to adding this, but could the test helpers use the environment variable that is already there?
I'm slightly concerned, disabling this may result in false positives in our test suite.That being said, I can be convince that it is a trade-off we should make.
@rwjblue @stefanpenner Basically what was happening is that the dependency checker was picking up on the consuming app's project file, and seeing that none of the dependencies were installed in the tmp folder. I'm all for putting a safer way in to disable this explicitly, and I will investigate adding an additional option to the ember test helper that would need to be passed when invoking the ember helper.
Maybe something like:
return ember(['command', 'args'], {disableDependencyChecker: true});
This looks good to me.
@quaertym this should be good to release, unfortunately I do not have those rights, so you will have to do this for us.
@quaertym thank you!
When testing blueprints, there is a need to circumvent the dependency checker since we're not actually installing npm and bower dependencies, we're just testing that the blueprint installs the correct files with the correct contents.
This PR adds a check for
project.cli.testing
which is set when the ember test helper is used here. We should not be running the dependency checker when testing, as we skip npm and bower installs while testing.