quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 38 forks source link

Warn, don't error if a dependency is the wrong version. #56

Closed runspired closed 7 years ago

runspired commented 8 years ago

Erroring out on missing dependencies is useful, erroring out on incorrect dependencies is a PITA. Often a dependency is mismatched because a new version is being trialed, and often it's a more recent version than the one in package.json. Warning would be much more useful.

stefanpenner commented 8 years ago

If a new version is being trailed, the package.json should be updated. Or linked, both cases work correctly currently

The hard error is because the system is measurably in a bad state, I would encourage this invariant remain.

runspired commented 8 years ago

The current behavior breaks the ember-update command for exactly this reason..

EDIT: broke? ember-update appears to have been removed.

stefanpenner commented 8 years ago

this is actually why (one of the reasons) why we removed update.

stefanpenner commented 8 years ago

I have plans to create a more standalone installer, as we have plans to do a more constraint based installation in the future. I hope to rectify the check+egg issue as part of that effort.

runspired commented 8 years ago

:+1:

runspired commented 8 years ago

I would still like to support the "update an addon from a clean install" situation. Needing to install everything before you can get to work is frustrating, especially when that becomes

If that was all you wanted to do for the day, it really cuts your time over being able to just do

stefanpenner commented 8 years ago

If that is something you want to work on, it would be greatly appreciated :P I don't forsee working on that for quite some time.. :(

runspired commented 8 years ago

I'm working on tools for helping maintain addon / app dependencies and facilitate faster scaffolding at the moment. Whether that will lead to wanting to work on a stand-alone installer, I don't know, but if it does I'll ping you.

sglanzer-deprecated commented 8 years ago

@runspired did your work on this lead anywhere? I'm doing research before starting a similar effort and I want to make sure the project is based on current information