quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 38 forks source link

Suggest `bower update` instead of `bower install` #60

Closed elwayman02 closed 7 years ago

elwayman02 commented 8 years ago

bower install is a confusing suggestion for outdated dependencies, due to Bower's frequent failure to upgrade versions w/ install if the package is not altogether missing.

stefanpenner commented 8 years ago

does this then also bump version deps? If so, that is somewhat overzealous and can result in even worse problems?

elwayman02 commented 8 years ago

Yes, as far as I'm aware bower update should handle installs and bumps both.

On Fri, Aug 12, 2016, 9:37 PM Stefan Penner notifications@github.com wrote:

does this then also bump version deps?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quaertym/ember-cli-dependency-checker/pull/60#issuecomment-239601747, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQ5qjdGPK7nilE863Joh04lpVHc61Mwks5qfUn4gaJpZM4JjmYH .

stefanpenner commented 8 years ago

then I believe that is more aggressive then we intend. The goal here is to detect cases where the existing ruleset described in package.json bower.json etc is not satisfied, but most likely could be satisfied. Basically, some team member has updated and fixed the world and now you pulled and it doesn't work, but very well could if you merely installed or removed dependencies and installed.

elwayman02 commented 8 years ago

Sorry, I misunderstood you. Now, bower will not change your prescribed versions. This command will only install the latest version that satisfies your bower.json

On Fri, Aug 12, 2016, 9:40 PM Stefan Penner notifications@github.com wrote:

then I believe that is more aggressive then we intend. The goal here is to detect cases where the existing ruleset described in package.json bower.json etc is not satisfied, but most likely could be satisfied. Basically, some team member has updated and fixed the world and now you pulled and it doesn't work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quaertym/ember-cli-dependency-checker/pull/60#issuecomment-239601863, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQ5qtByMlHmOmC15aaEoSQxURnxz3iCks5qfUrQgaJpZM4JjmYH .

quaertym commented 8 years ago

@stefanpenner r?

stefanpenner commented 8 years ago

@elwayman02 ah, so it is the same as?

rm -rf bower_components
bower install

Does it change resolutions at all?

elwayman02 commented 8 years ago

I don't believe so. As far as I know, the command should not touch your bower.json whatsoever.

On Sat, Aug 13, 2016, 7:10 AM Stefan Penner notifications@github.com wrote:

@elwayman02 https://github.com/elwayman02 ah, so it is the same as?

rm -rf bower_components bower install

Does it change resolutions at all?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/quaertym/ember-cli-dependency-checker/pull/60#issuecomment-239622752, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQ5qsipfgNdj9DxtURyeHYCnaLns0XXks5qfdBqgaJpZM4JjmYH .

stefanpenner commented 8 years ago

@elwayman02 if you can confirm that, then i feel good about this change.

elwayman02 commented 8 years ago

On my phone, so can't perform a test, but I've never seen it work that way. Someone wrote an npm package at one point to handle bumps, specifically because bower update does in fact respect the bower.json: https://www.npmjs.com/package/bower-update

On Sun, Aug 14, 2016, 2:24 PM Stefan Penner notifications@github.com wrote:

@elwayman02 https://github.com/elwayman02 if you can confirm that, then i feel good about this change.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quaertym/ember-cli-dependency-checker/pull/60#issuecomment-239698742, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQ5qvfqurKqMGVI7bYkwPasNrRl0Qghks5qf4eVgaJpZM4JjmYH .

stefanpenner commented 7 years ago

By default we no longer support bower, we can likely close this and hope bower vanishes....