search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 38 forks source link

Update to ember 2.10 family #63

Closed cibernox closed 7 years ago

cibernox commented 7 years ago

@stefanpenner Applied and travis green

stefanpenner commented 7 years ago

@cibernox do you mind adding the node versions ember-cli supports? Or is there a reason not to.

cibernox commented 7 years ago

@stefanpenner If you mean in the travis.yml, I already added 0.12. That is the minimum version now. You mean somewhere else?

stefanpenner commented 7 years ago

@stefanpenner If you mean in the travis.yml, I already added 0.12. That is the minimum version now. You mean somewhere else?

it would be great if we could test all the versions we officially support, which i believe requires travis.config to contain:

  - "0.12"
  - "4"
  - "6"
  - "7"
cibernox commented 7 years ago

I just learned that you can test agains more than one version of node that way. I'm not much into node, I always assumed that testing agains the minimum version was enough to guarantee compatibility forward. Done

stefanpenner commented 7 years ago

@cibernox makes sense, this was we catch issues early. Rather then as annoyances to ours users.