search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

(Requires Dropping Node v0.12.x support) Migrate jshint to eslint #67

Closed samtsai closed 7 years ago

samtsai commented 7 years ago

tests/.eslintrc.js rules borrowed from 'ember-cli'

/cc @quaertym @stefanpenner

stefanpenner commented 7 years ago

LGTM (although tests look unhappy)

samtsai commented 7 years ago

Let me investigate the test issues

samtsai commented 7 years ago

Looks like the classic SyntaxError: Use of const in strict mode

samtsai commented 7 years ago

@stefanpenner Ugh. Looks like we'll have to delay this unless we drop support for Node v0.12.x in this plugin.

Tests are now failing on eslint dependencies: https://ci.appveyor.com/project/quaertym/ember-cli-dependency-checker/build/43#L435

stefanpenner commented 7 years ago

Looks like we'll have to delay this unless we drop support for Node v0.12.x in this plugin.

I believe we have now

stefanpenner commented 7 years ago

rebased -> https://github.com/quaertym/ember-cli-dependency-checker/pull/74

stefanpenner commented 7 years ago

merged with #74