search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

Check tar.gz urls if they are specified in _from in package.json #88

Closed tschoartschi closed 6 years ago

tschoartschi commented 6 years ago

We are using tar.gz urls to manage some of our dependencies. This is due to the fact that these dependencies are very big binary blobs and we don't want to add these big blobs to a git repository. But tar.gz urls are not version checked in ember-cli-dependency-checker which often leads to confusion in our development team. Therefore I propose to check the _from property in the package.json if present, if not the old behavior should be applied.

tschoartschi commented 6 years ago

Seems like some checks of the CI failed, but I'm not sure what the problem was.

quaertym commented 6 years ago

@tschoartschi I restarted CI and it is all green now.

tschoartschi commented 6 years ago

@quaertym thanks for the clarification :) @rwjblue let me know what you think about this PR :) we would really need this kind of functionality

tschoartschi commented 6 years ago

@rwjblue sorry for being annoying, but do you have any feedback on this PR 😃

quaertym commented 6 years ago

@tschoartschi Please also squash commits.

quaertym commented 6 years ago

Thanks.

tschoartschi commented 6 years ago

@quaertym thank you for merging :)