search

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 37 forks source link

Update ember-cli #91

Closed jacobq closed 6 years ago

jacobq commented 6 years ago

This PR is just optional clean-up. e.g. run ember-cli-update to sync-up with what ember-cli v3.2.0 generates for new addons, and also tweak CI setup.

jacobq commented 6 years ago

I just realized that e-cli 3.2.0 drops node 4.x support, so attempting to use it triggers an 'incompatible module' error. Hence, if we want to update here as I was thinking then we'd need to drop 4.x support. Perhaps that should wait until a major release. Feel free to close this PR if you don't want to drop node 4.x support.

quaertym commented 6 years ago

Please also rebase master and squash commits.

jacobq commented 6 years ago

Do you want them all squashed (i.e. down to 1 single commit) or grouped (e.g. squash all of the e-cli updates, but keep the var->let/const separate)? (I was just following the recommendation of updating in stages but don't care either way.)

I've now rebased with master and squashed down to 3 commits (ember-cli update, var->let/const, and dependency upgrade).

quaertym commented 6 years ago

Thanks!