DependencyChecker: Reuse `resolveSync()` method on `Project` class

quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands

MIT License

40 stars 37 forks source link

DependencyChecker: Reuse `resolveSync()` method on `Project` class #94

Closed Turbo87 closed 5 years ago

Turbo87 commented 5 years ago

This will allow EmberCLI to implement Yarn PnP support without the dependency checker having to care about the details.

The other use of resolve in the ShrinkwrapChecker class seems irrelevant to this, as it is only used when npm shrinkwrap is used, and in that case it seems unlikely that Yarn PnP is used in parallel.

Resolves https://github.com/quaertym/ember-cli-dependency-checker/issues/92

/cc @rwjblue @quaertym

rwjblue commented 5 years ago

ember-cli-dependency-checker 3.1.0 published 🎉

quaertym commented 5 years ago

@rwjblue @Turbo87 Thanks! 👍