quaertym / ember-cli-dependency-checker

Ember CLI addon for checking missing node and bower dependencies before running ember commands
MIT License
40 stars 38 forks source link

Fixing issue with npm ci when dependency is defined as tar.gz url #99

Closed mansona closed 5 years ago

mansona commented 5 years ago

This is an issue that a friend of mine noticed when trying out the octane preview on CI, essentially when you define a dependency as a tar.gz url you can sometimes get situations where the _from url is prefixed with the name of the page and an @ symbol.

Steps to reproduce

Full error output

Missing npm packages:
Package: ember-source
  * Specified: https://s3.amazonaws.com/builds.emberjs.com/canary/shas/ed897e5a76c5c11010ce810e140e16e3e42417de.tgz
  * Installed: ember-source@https://s3.amazonaws.com/builds.emberjs.com/canary/shas/ed897e5a76c5c11010ce810e140e16e3e42417de.tgz

I don't 100% know the semantics of what this is doing but the change I'm submitting seems to fix it 🤷‍♂️

quaertym commented 5 years ago

Thanks.