Closed mdawar closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.53%. Comparing base (
9d5eef5
) to head (85f2a9f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for reporting this bug. However, this fix doesn't solve the case where two decimal numbers are equal, but they have different precision, for example:
a := MustFromInt64(100,1)
b:= MustFromInt64(10000,3)
udecimal.Zero == a.Sub(b) // false
I think the correct solution should be making zero value consistent across all operations. I'll create a fix for it
Thanks for reviewing my PR.
I'll close it in favor of your solution, I wasn't sure about it anyway and you are more familiar with the codebase.
This is a possible fix for #10.