Closed quagmt closed 4 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.89%. Comparing base (
5a55047
) to head (e506607
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR includes:
RoundAwayFromZero
RoundToInf
but I think people might mistakenly assume thatRoundToInf
is rounding to positive infinity. Renaming it toRoundAwayFromZero
provides more clarity and helps avoid confusionRoundHAZ
andRoundHTZ
. That's because short from of this method method isRoundAZ
which looks very similar toRoundHAZ
if we just glance. Also I feel like make it verbose will help reduce the cognitive complexity (no more mappingRoundAZ = Round Away From Zero
). It's also good to renameRoundHAZ
toRoundHalfAwayZero
so it's consistent and less complex but that change is beyond the scope of this PRStringFixed()
issue described in https://github.com/quagmt/udecimal/issues/23