search

quailjs / quail

Accessibility testing in the browser and on the server.
http://quailjs.org
Other
300 stars 44 forks source link

Faulty javascript or faulty DOM crash QUAIL, error handling possible? #126

Closed hannolans closed 10 years ago

hannolans commented 10 years ago

When a web page contains a faulty DOM or a faulty javascript QUAIL seems to crash. While that is probably not caused by QUAIL, we would like to get a notice that the test failed. Instead we get a part of the results and are not sure if that are all the results. We discovered this because we don't get the total results at the end.

Two examples of government sites that crash in our system: http://www.overheid.nl http://www.webrichtlijnen.nl

kevee commented 10 years ago

Was this an error in a PhantomJS environment, or a browser? I tried to inject quail into these pages with Chrome and it didn't balk.

This is one of the reasons I would like to refactor complete callbacks in #122.

hannolans commented 10 years ago

It's happening with PhantomJS. I checked the javascript in JSlint and it has some errors. Not sure if that is fatal for QUAIL. We didnt implement error handling with PhantomJS so far.

hannolans commented 10 years ago

We now have another setup when requesting PhantomJS and it doesn't break anymore on the above websites. We still need error handling though.