quakkels / rssdiscoveryengine

The RSS Discovery Engine exists to encourage people to use RSS for finding and consuming their news and current events.
MIT License
159 stars 9 forks source link

Rename `is_rss_content_type` to `is_feed_content_type` and simplify it somewhat #9

Closed lewiscollard closed 3 years ago

lewiscollard commented 3 years ago

Pardon the pull request spam; this is rooted in pedantry, the fact I like this project, and my deep-rooted desire to make extra work for myself.

I felt that is_rss_content_type was misnamed, so I renamed it. I also thought it could be simplified a little, so I simplified it a little. As with #7 (these will conflict when one of these is merged - and don't worry, I'll fix it), I've added a pytest dependency into the project so that you can have tests, and added a test to ensure that the function's behaviour is unchanged.

Thank you!

lewiscollard commented 3 years ago

@quakkels Rebased on master - merge conflicts fixed :)

quakkels commented 3 years ago

Thank you very much for your contributions! Much appreciated.