search

qualiture / ui5-validator

MIT License
42 stars 23 forks source link

Correction bug required fields #15

Closed AZn5ReD closed 5 years ago

AZn5ReD commented 5 years ago

Hello,

I corrected a bug for required values. When the required input is filled, the first validation set the state to None, but if you validate a second time, the field's state gets set back to Error again. The break allows to exit the "for loop" if there's a valid binding with an actual value.

I forked your plunker to reproduce the bug : http://plnkr.co/edit/2Wi9DVwJ80fsjznAyTUT?p=preview

Thank you so much for your work , by the way !

qualiture commented 5 years ago

Hi @AZn5ReD thanks for your contribution!

As the pull request is closed, I cannot merge it, unfortunately... Could you maybe reopen the pull request?

AZn5ReD commented 5 years ago

Hi @qualiture ,

Sorry, I pushed too many commits that are not relevant for the issue. I messed up a bit by deleting the repo, so I made an other PR #16 .