search

quandl / quandl-excel-windows

Quandl Excel Addin for Windows
https://www.quandl.com/tools/excel
13 stars 11 forks source link

Adds the MIT licence to the project. Resolves #35 #36

Closed jpgough closed 3 years ago

jpgough commented 4 years ago

Description

Note to the reviewer

Note to QA

Dependency

couture-ql commented 3 years ago

Looks good to me. Only snag is we enforce commits to be signed. If it wouldn't be too much trouble, could you amend your commit with a gpg signature?

Otherwise I'd be happy to rebase this myself, sign it, and push it up.

jpgough commented 3 years ago

Hi Jamie,

Happy for you to rebase this.

Thanks, Jim

On Thu, 1 Oct 2020 at 22:48, Jamie Couture notifications@github.com wrote:

Looks good to me. Only snag is we enforce commits to be signed. If it wouldn't be too much trouble, could you amend your commit with a gpg signature?

Otherwise I'd be happy to rebase this myself, sign it, and push it up.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quandl/quandl-excel-windows/pull/36#issuecomment-702415797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIXABD3UCID355P3C4CNUDSIT2KHANCNFSM4RNMGWDA .

couture-ql commented 3 years ago

Resolved in #37 with signed commit.