quandl / quandl-python

MIT License
1.37k stars 336 forks source link

build fail at test_get_merged_dataset_data_to_list #106

Closed sebix closed 6 years ago

sebix commented 6 years ago

Since some days, the builds are failing at openSUSES build system with this error:

[   32s] ======================================================================
[   32s] FAIL: test_get_merged_dataset_data_to_list (test.test_merged_dataset.GetMergedDatasetTest)
[   32s] ----------------------------------------------------------------------
[   32s] Traceback (most recent call last):
[   32s]   File "/home/abuild/rpmbuild/BUILD/quandl-python-3.3.0/test/test_merged_dataset.py", line 206, in test_get_merged_dataset_data_to_list
[   32s]     self.assertItemsEqual(results[index], expected_item)
[   32s] AssertionError: Expected, but missing:
[   32s]     [1436572800000000000L]
[   32s] Unexpected, but present:
[   32s]     [datetime.datetime(2015, 7, 11, 0, 0)]
[   32s] -------------------- >> begin captured logging << --------------------
[   32s] urllib3.connectionpool: DEBUG: Starting new HTTPS connection (1): www.quandl.com
[   32s] urllib3.connectionpool: DEBUG: https://www.quandl.com:443 "GET /api/v3/datasets/NSE/OIL/data?order=asc HTTP/1.1" 200 276
[   32s] urllib3.connectionpool: DEBUG: Starting new HTTPS connection (1): www.quandl.com
[   32s] urllib3.connectionpool: DEBUG: https://www.quandl.com:443 "GET /api/v3/datasets/SINGLE/COLUMN/data?column_index=1&order=asc HTTP/1.1" 200 227
[   32s] urllib3.connectionpool: DEBUG: Starting new HTTPS connection (1): www.quandl.com
[   32s] urllib3.connectionpool: DEBUG: https://www.quandl.com:443 "GET /api/v3/datasets/WIKI/MSFT/data?order=asc HTTP/1.1" 200 276
[   32s] --------------------- >> end captured logging << ---------------------
[   32s] 
[   32s] ----------------------------------------------------------------------

Full log is here: https://build.opensuse.org/build/devel:languages:python/openSUSE_Tumbleweed/x86_64/python-Quandl/_log

I suspect an incompatibility with some dependency (probably dateutil?), these are the ones used:

python3-base-3.6.5-3.1
python3-six-1.11.0-66.7
python3-idna-2.6-10.5
python3-3.6.5-3.1
python3-python-dateutil-2.6.1-14.14
python3-appdirs-1.4.3-8.11
python3-asn1crypto-0.24.0-9.4
python3-cssselect-1.0.3-21.2
python3-lxml-4.2.1-97.2
python3-mccabe-0.6.1-23.19
python3-py-1.5.2-59.4
python3-pyasn1-0.4.3-83.1
python3-pycodestyle-2.4.0-7.2
python3-pycparser-2.18-18.1
python3-cffi-1.11.5-51.4
python3-pyparsing-2.2.0-1.16
python3-packaging-17.1-21.2
python3-setuptools-39.2.0-128.1
python3-pbr-4.0.3-82.1
python3-linecache2-1.0.0-7.12
python3-traceback2-1.4.0-11.11
python3-pyflakes-1.6.0-50.3
python3-cryptography-2.2.1-106.3
python3-text-unidecode-1.1-5.4
python3-urllib3-1.22-44.2
python3-pycryptodome-3.6.1-13.1
python3-dnspython-1.15.0-54.1
python3-email_validator-1.0.2-3.9
python3-Faker-0.8.10-13.3
python3-pytz-2018.3-74.3
python3-certifi-2018.4.16-32.1
python3-chardet-3.0.4-59.1
python3-numpy-1.14.3-169.5
python3-devel-3.6.5-3.1
python3-Cython-0.28.2-113.2
python3-pandas-0.23.0-50.5
python3-requests-2.18.4-3.35
python3-factory_boy-2.9.2-15.15
python3-pyOpenSSL-17.5.0-2.4
python3-flake8-3.5.0-42.1
python3-unittest2-1.1.0-57.5
python3-mock-2.0.0-58.4
python3-nose-1.3.7-104.4
python3-httpretty-0.8.14-30.9
python3-inflection-0.3.1-3.4
python3-jsondate-0.1.2-5.4
python3-more-itertools-4.1.0-8.1
python3-ndg-httpsclient-0.4.0-6.10
mbasset commented 6 years ago

Thanks @sebix , We see that also our tests are failing due to what looks to be this same error. We are a bit busy with other projects atm but have an eye to fix this issue when time dictates.

mbasset commented 6 years ago

Hi @sebix we are looking in to addressing this issue on this branch https://github.com/quandl/quandl-python/pull/108

However looks like a change in some of the ways dates get converted with some newer plugins might be the issue. We are continuing to investigate.

ericvautour-quandl commented 6 years ago

Hello @sebix,

It looks like the issue was due to an upgrade in the pandas plugin. We have resolved this issue and all tests should be passing now.

Thanks,

sebix commented 6 years ago

The new release is published on pypi, but not on github: https://github.com/quandl/quandl-python/releases

ericvautour-quandl commented 6 years ago

Thanks @sebix,

This should now be resolved.

sebix commented 6 years ago

Thanks, works now.