search

quandl / quandl-python

MIT License
1.37k stars 336 forks source link

Remove dependency on unittest2 #113

Closed mcepl closed 5 years ago

mcepl commented 5 years ago

Quandl doesn't support Python 2.6 anyway, so there is no reason why to bother with adding an additional dependency on unittest2.

This patch fixes the situation.

mbasset commented 5 years ago

Hi @mcepl,

This sounds like a good suggestion and your patch seems reasonable at a first glance. Rather than a patch however can you please fork and provide a PR with this patch that we can review and comment with these changes. In anticipation of that we will close this issue as we can discuss further on the PR.

mcepl commented 5 years ago

I was filing twenty or so such patches last week. I really don't want to create useless forks for each of them. Do I have to?

sebix commented 5 years ago

@mbasset Seriously? Someone writes a patch for you fixing your software and you reject it because the author did not already have enough work with your software?