search

quangtt-rks / starter

A clean theme for Ghost blog
https://quangteomedia.com
MIT License
29 stars 9 forks source link

Add Chinese Simplified (zh_Hans) Translation #14

Closed craigary closed 5 years ago

craigary commented 5 years ago

Hi,

I love this theme so much and I was very upset when byfortress discontinued maintaining this theme. I am so happy you can bring it back.

I added Chinese Simplified (zh_Hans) Translation and I hope it helps you. #10

Also the font-size of Subscribe is a little large. a separate property in subscribe class might be better.

Screen Shot 2019-09-07 at 16 50 00

This is my first time trying to open a pull request, please let me know if I did something improperly.

quangtt-rks commented 5 years ago

Hi Craig! Right now I can not review or testing your PR, maybe 2 or 3 days later. But I really appreciate your contribution.

quangtt-rks commented 5 years ago

@craigary Hi Craig!

Also the font-size of Subscribe is a little large. a separate property in subscribe class might be better.

It's the same size with copyright text, maybe it's about your Chinese text is larger by itself.

On the previous day, I saw your commits of changing analytics service or comment system or... Did you discarded those changes?

quangtt-rks commented 5 years ago

Anyway, I have tested your translation file, it's OK. But it would be great if you change the file name from zh_Hans to zh_hans, just naming convention. Thank you!

craigary commented 5 years ago

@craigary Hi Craig!

Also the font-size of Subscribe is a little large. a separate property in subscribe class might be better.

It's the same size with copyright text, maybe it's about your Chinese text is larger by itself.

On the previous day, I saw your commits of changing analytics service or comment system or... Did you discarded those changes?

Yes, I made a commit and push to change analytics services and replace google plus button to reddit button, after I made this pull request. This is my first time do this and I didn't realize if I push the commits after a PR, it will still add to the list.

I believe it's irrelevant for this PR, so I force-pushed to revert, so make sure it doesn't messed up. I am still new to git so sorry for the confusion 😅

quangtt-rks commented 5 years ago

@craigary Thank you! Just make sure to set your Publication Language to zh_hans (exactly the same name with the locale file) to active Chinese Simplified. I am merging now.