search

quangv / hulk-hogan

Hogan.js for Express with support for Template Partials.
MIT License
37 stars 2 forks source link

Express 3.x support? #4

Closed steveworkman closed 12 years ago

steveworkman commented 12 years ago

Hi there,

Is there an example that uses hulk-hogan in express 3.x? I'm having a hard time getting it to work.

Steve

quangv commented 12 years ago

Hey Steve,

Thanks for checking out Hulk-Hogan... HH isn't tested on Express 3.x, (i'm still using Express 2.x) I will most likely check out 3.x once it's final/released.

I actually don't fully understand Express 3.x templating system yet...

Have you checked out https://github.com/visionmedia/consolidate.js ?

If Hogan + Consolidate.js + Express 3.x supports Sub-Partials then I most likely won't support Express 3.x; BUT if it doesn't then I most likely will :)

Sorry I can't be of more help, if you get HH working on 3.x, or decide to use regular Hogan, please share Thanks.

steveworkman commented 12 years ago

Thanks for getting back to me. I posted this on the express issue list too and TJ came up with an answer on how the template system needs to provide a function: https://github.com/visionmedia/express/issues/1094#issuecomment-5225560

I've looked at consolidate and it just has support for regular hogan, but oddly that doesn't support partials in 3.x yet. Have a look at TJ's post and see what you can do :-)

quangv commented 12 years ago

https://github.com/quangv/hulk-hogan/pull/7 this should add support for 3.0 by @christopherscott