search

quangv / hulk-hogan

Hogan.js for Express with support for Template Partials.
MIT License
37 stars 2 forks source link

add support for Express 3.0 templating #7

Closed christopherscott closed 12 years ago

christopherscott commented 12 years ago

Hey, I thought i'd push this since it seems to be working fine for me. The main change was the addition of an exports.__express function per the 2.x -> 3.x specs (https://github.com/visionmedia/express/wiki/Migrating-from-2.x-to-3.x). Also, I aliased the compile function to a local variable for convenience.

The only thing was, I'm not sure how you wanted to handle the Express dependency, and the tests. The existing tests passed after my change, but I guess you'll want Express 3.0 tests too. I'll see if I can get some time to work on it this weekend. Anyway, thanks for the lib, I love hogan and mustache :)

quangv commented 12 years ago

Hey Christopher,

Awesome! #4 would be happy. :)

Looks good. I'll pull it in soon.