Add basic GitHub templates

quanshousio / ToastUI

A simple way to show toast in SwiftUI.

MIT License

578 stars 45 forks source link

Add basic GitHub templates #1

Closed LucasCarioca closed 4 years ago

LucasCarioca commented 4 years ago

Hey I was the guy that responded about possibly contributing back.

I figured I would go ahead and start off by helping with some basic GitHub templates to make collecting issues, requests and PRs a little cleaner and more organized.

I submitted my thoughts on a few templates tailored a bit for a swift project. Let me know your thoughts.

You can see what these will look like in my fork https://github.com/LucasCarioca/ToastUI/issues/new/choose

quanshousio commented 4 years ago

Thank you so much for your first contribution. I truly appreciate it. I've read all the templates and have some thoughts:

but_report_template.md has a typo. It should just be bug_report.md to be consistent with the name that GitHub sets by default when you create the template.
Add a full stop to all inline comments that consist of more than one sentence.

LucasCarioca commented 4 years ago

Alright sounds good ill make the file name change.

Not sure what you mean by this though:

Add a full stop to all inline comments that consist of more than one sentence.

quanshousio commented 4 years ago

Add a full stop to all inline comments that consist of more than one sentence.

I meant block comments, sorry for being wordy here. I just made suggested changes in a211e19.

Moreover, I'm seeing bug_report.md still has typo in its filename in the last commit. Could you fix that?

LucasCarioca commented 4 years ago

Oops totally overlooked that. Fixed as well.

Moreover, I'm seeing bug_report.md still has typo in its filename in the last commit. Could you fix that?

LucasCarioca commented 4 years ago

Anymore changes on this @quanshousio?