Solves the issue for undefined gates (cr2, cr4, cr8, crz)

quantastica / quantum-circuit

Quantum Circuit Simulator implemented in JavaScript

MIT License

243 stars 47 forks source link

Solves the issue for undefined gates (cr2, cr4, cr8, crz) #22

Closed Kaustuvi closed 5 years ago

Kaustuvi commented 5 years ago

Hi @perak, This PR solves the issues mentioned in #21. Please let me know if there are mistakes/other workarounds! :)

perak commented 5 years ago

Hi @Kaustuvi

Thank you very much for the PR, but problem is that almost entire file is changed and it is hard for review:

Looks like you (or your editor) changed coding style and there is more than 2k changes.

Can you pls change only code where you find bugs and make new PR?

perak commented 5 years ago

Plus, my latest commit is shown in diff, so looks like something is messed up with git.

I will merge your changes, but please try to make new clean branch and modify code there.

Thanks!

Kaustuvi commented 5 years ago

I probably formatted the file and that's why there are so many changes. Also, I merged your latest commit after raising the PR and that probably messed up something! I am sorry for this mistake. :( Should I make a new PR now?

perak commented 5 years ago

It is best if you make new one. Thanks!

Kaustuvi commented 5 years ago

Okay! I am making a new one! :)