search

quantastica / quantum-circuit

Quantum Circuit Simulator implemented in JavaScript
MIT License
243 stars 47 forks source link

vite, jest, ESM, ES classes #88

Open dmvjs opened 2 weeks ago

dmvjs commented 2 weeks ago

need to verify that built files dont have any issues all tests pass

perak commented 2 weeks ago

Ouch! A lof of for review 😄

Note that tests are not exhaustive (actually, tests are minimal), and we use this package in multiple projects internally (yes, technical debt it is), so I need to carefully test before merging.

Thank you for this btw! Project started when ES6 was beta and not widelly supported by browsers and node. But we really need to modernize it.

dmvjs commented 2 weeks ago

Thanks for taking a look, no rush from my side I just got excited about this repo and thought I could contribute. I know it is a huge PR and I can break it up any way you like if it is helpful.

Upgrading dependencies and modernizing JS repos is kind of my thing. If I can find a good way to test the built files I will.

Also these changes are all landed into my fork in case you want to play with it there, its on my master https://github.com/dmvjs/quantum-circuit

dmvjs commented 4 days ago

I'm not sure if you have had any time to test this yet, but I can peel it off into layers if that is more helpful. I didn't intend for the PRs to collapse into a single one, apologies.