Closed kstinsonqc closed 7 years ago
I think that it would make more sense to fix KfsFileAttr and stat(), by ensuring that java KfsFileAttr has all fields that the c++ equivalent has, use stat() call, and deprecate all accessor methods that fetch single fields of file attribute, rather than creating a new one.
Also please change KfsClientImpl::ReadDirectory() / DirectoryIterator() / kfs_readdirplus() to pass all fields while you're on this.
And for file attributes report chunkCount()
Merging #214 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #214 +/- ##
======================================
Coverage 75.1% 75.1%
======================================
Files 8 8
Lines 245 245
Branches 31 31
======================================
Hits 184 184
Misses 42 42
Partials 19 19
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a8b856c...a156dc1. Read the comment docs.
PR update to undo the addition of getCreationTime() in favor of exposing more of the client's KfsFileAttr files to KfsAccess's version.
Adds getCreationTime method to KfsAccess.
@mikeov @mckurt @zimmix