Update people - Githubissues

quanteda / quanteda.org

Quanteda Initiative website

https://quanteda.org

0 stars 0 forks source link

Update people #24

Closed stefan-mueller closed 5 years ago

stefan-mueller commented 5 years ago

Fixes typo in @koheiw's bio
Updates Cornelius Puschmann's affiliation
Adjusts the spacing between boxes: If we use </div> five times between the first and second row, the spaces between the boxes are incoherent in the mobile version of the website, which merges the two columns into a single column.

stefan-mueller commented 5 years ago

@ciflikli: after building the page, I realised that something is still wrong with the spacing between the first and second row. Could you adjust the code before merging the PR?

ciflikli commented 5 years ago

@stefan-mueller removing the </div> at line 53 disturbs the grid (like you observed); further, when zoomed out/on larger screens, the first three boxes are rendered correctly however I get pushed at the end of the second row while you are placed on the third row (see image).

Making two rows seems to fix the issue (i.e. the existing code); can you provide an image of the distortion you see on mobile?

stefan-mueller commented 5 years ago

Below are screenshots of the website displayed on a smartphone. The vertical distance at the transition between Aki and you is around twice as large as the distances between the other QI members. Of course not a major issue, but I thought this can be fixed by adjusting the distance between the first and second row.

problem_mobile_website

kbenoit commented 5 years ago

Great, and feel free to merge once that's done, since these are just typo changes.

stefan-mueller commented 5 years ago

Since the spacing issue was resolved in #27, I close this PR and delete the branch.