quanteda / quanteda.textmodels

Text scaling and classification models for quanteda
42 stars 6 forks source link

Fix svm issues #48

Closed kbenoit closed 3 years ago

kbenoit commented 3 years ago

The title is a bit misleading, since there is more than that in here. Changes are:

Once this is merged I will resubmit to CRAN, since they've emailed me about a test breaking the M1Mac build tests.

codecov[bot] commented 3 years ago

Codecov Report

Merging #48 (f257976) into master (07fe5fd) will increase coverage by 0.13%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   64.14%   64.27%   +0.13%     
==========================================
  Files          19       19              
  Lines        2535     2536       +1     
==========================================
+ Hits         1626     1630       +4     
+ Misses        909      906       -3     
Impacted Files Coverage Δ
R/textmodel_ca.R 97.18% <ø> (ø)
R/textmodel_lr.R 83.54% <ø> (ø)
R/textmodel_lsa.R 83.92% <ø> (ø)
R/textmodel_nb.R 93.68% <ø> (ø)
R/textmodel_svmlin.R 64.03% <ø> (+0.87%) :arrow_up:
R/textmodel_wordfish.R 84.07% <ø> (ø)
R/textmodel_svm.R 94.52% <100.00%> (+2.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07fe5fd...0110f7f. Read the comment docs.

kbenoit commented 3 years ago

On textmodel_svmlin() v textmodel_svmlin(), see #49.