search

quanteda / quanteda.textstats

Textual statistics for quanteda
GNU General Public License v3.0
14 stars 2 forks source link

Remove cacheing from textstat_summary() #25

Closed kbenoit closed 3 years ago

kbenoit commented 3 years ago

Solves #24 by excising this altogether.

We needed this to remove inefficiencies when people were calling summary() for their corpus, but that's not how textstat_summary() works, or any of the other textstat functions now. Let's deal with cacheing if we want in the place where the functions exist, which is quanteda, and consider adding them back if we solve the problems with Solaris.

kbenoit commented 3 years ago

I think we have issues in our CI scripts, not sure what is the problem here. The code is fine.

kbenoit commented 3 years ago

@koheiw I think this is the best solution for now and solves the Solaris issues. We can address them in the summary() changes in the main package, and bring them back if needed.

I'll update the package as soon as once we've resolved this, since the errors are blocking the submission of quanteda.textplots.

Ignore the Error: Error: class "textstat_proxy" is not exported by 'namespace:quanteda' error since that's not showing on CRAN or locally - and is not true anyway!