koheiw commented 3 years ago

Due to the change in how Canberra distance is computed, the tests need to be updated. Please also update CRAN.

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (b3124cc) into master (bf38c37) will not change coverage. The diff coverage is n/a.

:exclamation: Current head b3124cc differs from pull request most recent head 973fdfe. Consider uploading reports for the commit 973fdfe to get more accurate results

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files          16       16           
  Lines        1170     1170           
=======================================
  Hits          962      962           
  Misses        208      208

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf38c37...973fdfe. Read the comment docs.

kbenoit commented 3 years ago

Thanks @koheiw. When do you plan to update proxyC?

koheiw commented 3 years ago

proxyC is ready to resubmit today. There are multiple important bug fixes and new diag and smooth arguments. You might want to expose them in textstat_simil().

There are a lot of tests of the proxyC functions in quanteda.textstat, including one in this PR. I think they should be removed. proxyC has much better test coverage now.

kbenoit commented 3 years ago

OK happy to update that. What about catching #35 before we resubmit quanteda.textstats? We could return NA for the emoji field if the ICU version is not new enough. I was trying to figure out when this was introduced but my initial search did not produce an answer.

If you think this is not simple enough to do quickly, we can resubmit without solving that.

quanteda / quanteda.textstats

Reflect change in how Canberra distance is computed in proxyC v2.0 #36

Codecov Report