koheiw commented 3 years ago

For #24 and #35. I could not figure out when Emoji_Presentation became available, but ICU 11.0 seems to be the turning point. Please check the emoji column become all NA on your old machine.

Starting with Version 11.0 of this specification, the repertoire of emoji characters is synchronized with the Unicode Standard, and has the same version numbering system. For details, see Section 1.5.2, Versioning.

http://www.unicode.org/reports/tr51/#Emoji_Properties

koheiw commented 3 years ago

Please add a test if you have any idea...

koheiw commented 3 years ago

It is version 10 on Mac... Should we disable before 10 or 9?

codecov[bot] commented 3 years ago

Codecov Report

Merging #37 (07f2a4e) into master (7afe8dc) will decrease coverage by 0.02%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   82.22%   82.19%   -0.03%     
==========================================
  Files          16       16              
  Lines        1170     1174       +4     
==========================================
+ Hits          962      965       +3     
- Misses        208      209       +1

Impacted Files	Coverage Δ
R/textstat_summary.R	`97.43% <80.00%> (-2.57%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7afe8dc...07f2a4e. Read the comment docs.

kbenoit commented 3 years ago

Let's say before 9 - so yes I agree with the call you made. :+1:

kbenoit commented 3 years ago

Not sure how to test this except manually. Works on Ubuntu 16.04 however.

quanteda / quanteda.textstats

Disable emoji count when ICU is old #37

Codecov Report