search

quanteda / readtext

an R package for reading text files
https://readtext.quanteda.io
120 stars 28 forks source link

Strange tests expectations #117

Closed koheiw closed 6 years ago

koheiw commented 6 years ago

There are some strange tests that are falling on my Linux. I have no idea how these tests passed on other platforms.

OK: 156 SKIPPED: 1 FAILED: 3
  1. Error: test structured readtext with glob-style mask (@test-readtext.R#68) 
  2. Error: text vectors have names of the files they come from by default (bug 221) (@test-readtext.R#533) 
  3. Error: readtext called with textfield works with deprecation warning (@test-readtext.R#781)

Error 1

This should be reading CSV files in https://github.com/quanteda/readtext/tree/master/tests/data/csv but there are only 3 files, and test3.csv even does not have a column called text. https://github.com/quanteda/readtext/blob/0fbfe656998a53cc01b2e58f6436535eebd9d9a4/tests/testthat/test-readtext.R#L67-L80

Error 2 and 3

Both caused by Error 1: https://github.com/quanteda/readtext/blob/0fbfe656998a53cc01b2e58f6436535eebd9d9a4/tests/testthat/test-readtext.R#L533-L542

https://github.com/quanteda/readtext/blob/0fbfe656998a53cc01b2e58f6436535eebd9d9a4/tests/testthat/test-readtext.R#L780-L786