quanteda / readtext

an R package for reading text files
https://readtext.quanteda.io
120 stars 28 forks source link

Feature/xpath separator (fixes #93) #99

Closed adamobeng closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #99 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files           6        6           
  Lines         440      440           
=======================================
  Hits          381      381           
  Misses         59       59
Impacted Files Coverage Δ
R/get-functions.R 83.33% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5eaf8e...d7ceb2d. Read the comment docs.

codecov[bot] commented 7 years ago

Codecov Report

Merging #99 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files           6        6           
  Lines         440      440           
=======================================
  Hits          381      381           
  Misses         59       59
Impacted Files Coverage Δ
R/readtext.R 82.85% <ø> (ø) :arrow_up:
R/get-functions.R 83.33% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5eaf8e...c4d37a0. Read the comment docs.

adamobeng commented 7 years ago

Good question. Didn't change any user-visible function signatures, so maybe just in a vignette?

kbenoit commented 7 years ago

It implies we should document the get functions, and describe the additional functions that can be passed through .... I can do that.

adamobeng commented 7 years ago

OK, that would be great. In case this would make for a better design, is there a sensible way to pass ... to more than one function so they only consume what they want?

kbenoit commented 7 years ago

It will work the way you've done it here, where get_xml() will recognise the collapse argument separately from the other ellipsis arguments, but it's all unnamed ellipsis in the calling function readtext(). For now I'll add this documentation just to readtext().