Closed adamobeng closed 7 years ago
Merging #99 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 6 6
Lines 440 440
=======================================
Hits 381 381
Misses 59 59
Impacted Files | Coverage Δ | |
---|---|---|
R/readtext.R | 82.85% <ø> (ø) |
:arrow_up: |
R/get-functions.R | 83.33% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c5eaf8e...c4d37a0. Read the comment docs.
Good question. Didn't change any user-visible function signatures, so maybe just in a vignette?
It implies we should document the get functions, and describe the additional functions that can be passed through ...
. I can do that.
OK, that would be great. In case this would make for a better design, is there a sensible way to pass ...
to more than one function so they only consume what they want?
It will work the way you've done it here, where get_xml()
will recognise the collapse
argument separately from the other ellipsis arguments, but it's all unnamed ellipsis in the calling function readtext()
. For now I'll add this documentation just to readtext()
.
Codecov Report
83.33% <100%> (ø)
Continue to review full report at Codecov.