search

quanticc / lawena-recording-tool

Simple movie recording tool for Source Engine games
http://lawena.github.io/
GNU General Public License v3.0
80 stars 15 forks source link

Add exec VDM segment #110

Closed joekiller closed 6 years ago

joekiller commented 6 years ago

Occasionally there are commands that cannot be run on the same tick as a startmovie command. This PR allows for independent exec segments of the VDM editor.

This PR also fixes a bug where an editor option will linger if while updating a field you click the clear button.

Ticks are now immutable.

joekiller commented 6 years ago

thanks @quanticc I'll add the polish

quanticc commented 6 years ago

Thanks @joekiller - pushed to preview branch as well

joekiller commented 6 years ago

I was thinking that it might be nice to have exec between record ticks. Ie any exec commands that follows an exec_record or record is interleaved into that record segment.

@quanticc what do you think of that?

joekiller commented 6 years ago

Nvm I see you did some bug fixing. Very nice. and I think even if vdm ticks are out of order, TF2 seems to fire all of them at the same time.

quanticc commented 6 years ago

As far as I know, the order of the segments doesn't matter in VDM files.

I'm going to push a fix imposing a certain order on generation, due to issues with initial SkipAhead and last stopdemo segments using incorrect ticks.

quanticc commented 6 years ago

Also going to reformat the source code, noticed that my IDE wasn't honoring my own .editorconfig file.