quanticchaos / OctoPrint-Webcamsb

9 stars 4 forks source link

Camera 2 doesn't store horizontal flip #13

Open shawarden opened 3 years ago

shawarden commented 3 years ago

Expected: Setting second sidebar camera's horizontal flip to YES would remember this setting and horizontally flip the second camera after refreshing OctoPrint Web UI.

Result: Refreshing the OctoPrint WebUI with CTRL + F5 shows no camera flip and the settings has Flip Horizontally back to NO.

Procedure:

  1. Settings > Plugins > Sidebar Webcam
  2. Second (2) camera's Flip Horizontally to YES
  3. Save
  4. Second Camera is not flipped.
  5. Settings > Plugins > Sidebar Webcam
  6. Second (2) camera's Flip Horizontally is still YES
  7. Save or Close
  8. Refresh OctoPrint Web UI with CTRL + F5
  9. Second Camera is NOT flipped horizontally.
  10. Settings > Plugins > Sidebar Webcam
  11. Second (2) camera's Flip Horizontally is NO

Flip Vertically and Rotate are remembered for second (2) camera.

Plugin: 0.1.8
OctoPrint: 1.4.2
Python: 3.8.2
MJPG Streamer: snap 42 (f387bb44e6c087271b763b27da998bf2e06c4f5d)
OS Ubuntu: 20.04.1 LTS 5.4.0-42-generic #46-Ubuntu SMP x86_64
quanticchaos commented 3 years ago

I'll check it.

luggiduggi commented 3 years ago

I have the same problem. I noticed, that in the code, (/templates/webcamsb_settings.jinja2, line 40) the "value:" is missing. Could this be the issue?

luggiduggi commented 3 years ago

I was able to flip it by clearing the cache and then manually editing ~/.octoprint/config.yaml by including "f2x: '1'" in the webcamSB: section. Only f1x, f1z and f2z were originally stored in this file. Please check into this - would be very helpful.