quantified-uncertainty / metaforecast

Fetch forecasts from prediction markets/forecasting platforms to make them searchable. Integrate these forecasts into other services.
https://metaforecast.org/
MIT License
57 stars 5 forks source link

More typescript & cleanups #23

Closed berekuk closed 2 years ago

berekuk commented 2 years ago

This is a second step in the transition to TypeScript (#7).

For now I:

Some axios calls had options not appropriate for axios, e.g. referrer, agent and credentials. I just commented those since everything works without them. But it's interesting that one of those (agent) was responsible for BACKUP_PROXY stuff on goodjudgement. Unsure, should I fix BACKUP_PROXY properly, or are we ok without it?

PS: enabling strict in tsconfig.json (i.e., the actually useful mode which gives most benefits from using typescript) displays 523 errors. I'll either temporarily turn it on from time to time and try to bring this number down (without spending too much time on this), or wait until other code cleanups first.

netlify[bot] commented 2 years ago

Deploy Preview for metaforecast ready!

Name Link
Latest commit edeefdb3f533b6327620445fe2fea48749f22b03
Latest deploy log https://app.netlify.com/sites/metaforecast/deploys/6240d8051638e70008364247
Deploy Preview https://deploy-preview-23--metaforecast.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

NunoSempere commented 2 years ago

So the goodjudgment script doesn't currently work on heroku. But I figured it did work if I used, e.g., some proxies from Hetzner (https://spys.one/proxy-asn/24940/). This wasn't working, so my workaround is to run a crontab on my machine. But fixing the proxying would be great.

NunoSempere commented 2 years ago

Feel free to merge this @berekuk; I'm not seeing how that could cause any particular problems.

NunoSempere commented 2 years ago

Yeah, I'm going to merge this; don't think anything particularly bad will happen.