search

quantified-uncertainty / metaforecast

Fetch forecasts from prediction markets/forecasting platforms to make them searchable. Integrate these forecasts into other services.
https://metaforecast.org/
MIT License
57 stars 5 forks source link

[semi-urgent] Footer display in dsahboards is fucked up #45

Closed NunoSempere closed 2 years ago

NunoSempere commented 2 years ago

See e.g., https://metaforecast.org/dashboards?dashboardId=ad190968c6, or the dashboards embedded in https://globalguessing.com/russia-ukraine-forecasts/

berekuk commented 2 years ago

Oops. I'll fix it in 1-2 hours.

berekuk commented 2 years ago

Fixed in 3771b53e4fe391cc32eba1497c6c343c9974d1cc.

There are two issues here.

One is that I fucked up platform labels by not being careful with adding labels in all cases. So dashboard cards displayed goodjudgmentopen instead of GJOpen. There are currently two types, Forecast and FrontendForecast; I changed the type signature of <DisplayForecasts> component in my previous commit, but unfortunately haven't got around to changing types for /dashboards page, and since any type is allowed and most return values are still any, typescript haven't caught this, and I wasn't careful enough.

Second issue is that CSS could accomodate this situation better. I'll look into CSS now before closing this issue, to avoid later complications.

berekuk commented 2 years ago

I'll look into CSS now before closing this issue

displayForecasts code turned out to be more complicated than I expected. Closing this issue for now.

NunoSempere commented 2 years ago

Thanks for dealing with this!