Remove "noImplicitAny": false in components

quantified-uncertainty / squiggle

An estimation language

https://squiggle-language.com

MIT License

155 stars 23 forks source link

Remove "noImplicitAny": false in components #1709

Open berekuk opened 1 year ago

berekuk commented 1 year ago

Context:

I tried to remove it after triggering a pretty bad case of unsafe types ({foo: "bar"}[0] is any)
but Lezer types are broken: first, they don't provide exports.types field, second, even after I tried to patch node_modules/@lezer/*/package.json by hand and set explicit context: any in squiggle.ts, it didn't work (because generated code is problematic too)

@cab404 this might require PRs to upstream to fix. I couldn't find any issues in https://github.com/lezer-parser/lezer.

berekuk commented 1 year ago

I guess, alternatively, we could try to provide a .d.ts file for generated code, or exclude it from strict typescript checks somehow, and use context: any for squiggle.ts code.

I'd prefer to have "noImplicitAny": true in the entire components repo and sacrifice the type safety in languageSupport, if that's easier for now.