Gutter items patches - Githubissues

quantified-uncertainty / squiggle

An estimation language

https://squiggle-language.com

MIT License

150 stars 23 forks source link

Gutter items patches #3062

Closed berekuk closed 8 months ago

berekuk commented 8 months ago

This does a bunch of things on top of #2980, described in this Discord thread.

Short summary:

remove onFocusByEditorLine prop
move some styles from CSS to React/Tailwind
use new approach to configuring the extension (CodeMirror fields instead of useReactiveExtension)
improve AST traverse algorithm
cache markers in some cases(they won't be updated on all state changes, only on doc or simulation changes)

For now, I just hide the gutter when the source and the simulation don't match. This is better when before, when markers were wrong for a split-second; now they just get hidden and revealed again if the edit didn't cause simulation changes.

It's possible to improve this, but that's out of scope for this PR.

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: dfa1dc11ab3bca3a388551c133e8d6e5533a6299

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quri-hub	✅ Ready (Inspect)	Visit Preview	Feb 13, 2024 1:39am
squiggle-components	✅ Ready (Inspect)	Visit Preview	Feb 13, 2024 1:39am
squiggle-website	✅ Ready (Inspect)	Visit Preview	Feb 13, 2024 1:39am

1 Ignored Deployment

OAGr commented 8 months ago

I'll spend more time reviewing the generator part later, but overall this code looks very good, and the functionality seems to work well too. Great work here!