search

quantified-uncertainty / squiggle

An estimation language
https://squiggle-language.com
MIT License
150 stars 23 forks source link

Node v20 #3120

Closed berekuk closed 6 months ago

berekuk commented 6 months ago

Context: in #3086, we had weird problems with pnpm not working correctly in CI, while it was fine on my machine.

I'm not sure if Node v18 in CI is to blame (I'm on v20 locally), but v20 has been out for quite some time now, so it makes sense to enable it for CI, which I did in 9cab5903e648ccae29fea342dbc3aff1104d2d7b.

Vercel still defaults to v18, unless engines.node is set. So we should upgrade it too.

Technically v20 support on Vercel is still in beta, but I don't expect that we'll hit any issues in practice.

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: cdfe849818c3db548893e91618b21d34f44e4444

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Mar 27, 2024 9:15pm
quri-ui ✅ Ready (Inspect) Visit Preview Mar 27, 2024 9:15pm
squiggle-components ✅ Ready (Inspect) Visit Preview Mar 27, 2024 9:15pm
squiggle-website ✅ Ready (Inspect) Visit Preview Mar 27, 2024 9:15pm
berekuk commented 6 months ago

Huh, Squiggle Hub on Vercel fails with a cryptic error:

SyntaxError: Unexpected token '<', "<!doctype "... is not valid JSON
    at JSON.parse (<anonymous>)
    at parseJSONFromBytes (node:internal/deps/undici/undici:5329:19)
    at successSteps (node:internal/deps/undici/undici:5300:27)
    at fullyReadBody (node:internal/deps/undici/undici:1447:9)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async specConsumeBody (node:internal/deps/undici/undici:5309:7)
    at async d (/var/task/packages/hub/.next/server/app/page.js:1:42294)
    at async r (/var/task/packages/hub/.next/server/app/page.js:1:43001)
    at async g (/var/task/packages/hub/.next/server/app/page.js:1:40502)

So I'll drop this for now.

OAGr commented 6 months ago

That's pretty annoying. Guess we can just retry every so often, to see if it's fixed. Though we might want to wait until it leaves beta to be safe.