search

quantified-uncertainty / squiggle

An estimation language
https://squiggle-language.com
MIT License
148 stars 22 forks source link

Fix var refs in function annotations #3155

Closed berekuk closed 3 months ago

berekuk commented 3 months ago

Fixes #3141 Fixes #3111

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 5253fa8a7326b5375338246c7e12ed7815757e93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Apr 4, 2024 9:04pm
squiggle-components ✅ Ready (Inspect) Visit Preview Apr 4, 2024 9:04pm
squiggle-website ✅ Ready (Inspect) Visit Preview Apr 4, 2024 9:04pm
1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **quri-ui** | ⬜️ Ignored ([Inspect](https://vercel.com/quantified-uncertainty/quri-ui/AnPoo1akxXUwVB9AgkuNyCmootxw)) | [Visit Preview](https://quri-ui-git-compiler-bug-quantified-uncertainty.vercel.app) | Apr 4, 2024 9:04pm |
OAGr commented 3 months ago

Does this fix https://github.com/quantified-uncertainty/squiggle/issues/3111 too? (It doesn't have to, just curious)

OAGr commented 3 months ago

Kudos for fixing so quickly!

berekuk commented 3 months ago

Does this fix https://github.com/quantified-uncertainty/squiggle/issues/3111 too? (It doesn't have to, just curious)

It has a new weird error on that issue, so there's another bug that I'm now investigating.

berekuk commented 3 months ago

Specs/decorators are fixed now too; https://squiggle-website-git-compiler-bug-quantified-uncertainty.vercel.app/playground?v=dev#code=eNotTbsKwzAM%2FBWhKYXQpVsgUOgndNUiYgVCYynEShfH%2Fx4bstxxD%2B4yBpn5WP1jQXDAtMkEI3wrPSP%2FpCMFyMpRBiDckxP2EGw6oqizL6a3v3tq0Z%2FXJbDXdj7lBClQSB%2BkpO823TWocjarLy8sFxGLK%2Fg%3D

OAGr commented 3 months ago

W00t, nice