search

quantified-uncertainty / squiggle

An estimation language
https://squiggle-language.com
MIT License
148 stars 22 forks source link

Avoid canvas dev dependency #3177

Closed berekuk closed 2 months ago

berekuk commented 2 months ago

Use https://github.com/hustcc/jest-canvas-mock on components.

We also have jest-environment-jsdom in hub, which peer-depends on canvas, but it's not important for now because we don't have any frontend tests in hub.

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: f2e1cf072a133cc71f1e032dcefcc810b040e89a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Apr 13, 2024 9:31pm
quri-ui ✅ Ready (Inspect) Visit Preview Apr 13, 2024 9:31pm
squiggle-components ✅ Ready (Inspect) Visit Preview Apr 13, 2024 9:31pm
squiggle-website ✅ Ready (Inspect) Visit Preview Apr 13, 2024 9:31pm
OAGr commented 2 months ago

Surprised we don't need canvas for prod, that's great to know.