quantified-uncertainty / squiggle

An estimation language
https://squiggle-language.com
MIT License
150 stars 23 forks source link

useSimulator refactorings #3198

Closed berekuk closed 5 months ago

berekuk commented 5 months ago

This PR is done on top of #3158, and for now points to that branch.

This does a few things:

Important downside: the viewer is flickering again, and the reported execution times are higher (~10ms). The requestAnimationFrame logic is now in EmbeddedRunner, because we only need it for those runners, and we don't need extra delay for WebWorkerRunner that will become the default in the future.

I out of ideas how to fix that, and tbh I think we should just tolerate it until WebWorkerRunner will become the default (hopefully soon, but it's not ready yet).

Also, dice indicator is still unreliable, but it's unreliable in main branch too.

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: c8fee1ec976f2dff33474bd16cf19fef21adbde4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Apr 26, 2024 6:56pm
quri-ui ✅ Ready (Inspect) Visit Preview Apr 26, 2024 6:56pm
squiggle-components ✅ Ready (Inspect) Visit Preview Apr 26, 2024 6:56pm
squiggle-website ✅ Ready (Inspect) Visit Preview Apr 26, 2024 6:56pm