Closed berekuk closed 5 months ago
Latest commit: c8fee1ec976f2dff33474bd16cf19fef21adbde4
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
quri-hub | ✅ Ready (Inspect) | Visit Preview | Apr 26, 2024 6:56pm |
quri-ui | ✅ Ready (Inspect) | Visit Preview | Apr 26, 2024 6:56pm |
squiggle-components | ✅ Ready (Inspect) | Visit Preview | Apr 26, 2024 6:56pm |
squiggle-website | ✅ Ready (Inspect) | Visit Preview | Apr 26, 2024 6:56pm |
This PR is done on top of #3158, and for now points to that branch.
This does a few things:
useSimulator
and renamesuseSimulatorManager
touseSimulator
(they were too deeply interconnected to keep them separate, and the second hook wasn't used anywhere by itself)Important downside: the viewer is flickering again, and the reported execution times are higher (~10ms). The
requestAnimationFrame
logic is now inEmbeddedRunner
, because we only need it for those runners, and we don't need extra delay forWebWorkerRunner
that will become the default in the future.I out of ideas how to fix that, and tbh I think we should just tolerate it until
WebWorkerRunner
will become the default (hopefully soon, but it's not ready yet).Also, dice indicator is still unreliable, but it's unreliable in
main
branch too.