Codemirror refactorings and tooltips improvements

quantified-uncertainty / squiggle

An estimation language

https://squiggle-language.com

MIT License

145 stars 22 forks source link

Codemirror refactorings and tooltips improvements #3312

Closed berekuk closed 2 weeks ago

berekuk commented 2 weeks ago

This PR contains two changes (unfortunately both are in a single diff).

First, it gets rid of useReactiveExtension custom hook that we used before to pass React props to Codemirror. I've promised this refactoring in this older comment, and now it's implemented everywhere else.

Most of the interesting implementation for this is in CodeEditor/fields.ts, with comments. Some fun parts are also in extensionFromFacets function in CodeEditor/utils.ts.

Second, it adds a few user-facing features:

variables with tooltips have cursor-pointer hover:bg-slate-200 class
import variables have tooltips:

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quri-hub	✅ Ready (Inspect)	Visit Preview	Jun 13, 2024 6:52pm
squiggle-components	✅ Ready (Inspect)	Visit Preview	Jun 13, 2024 6:52pm
squiggle-website	✅ Ready (Inspect)	Visit Preview	Jun 13, 2024 6:52pm

1 Ignored Deployment

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: d652d8c5c29ce94f032f43c79f7951c4c04db4b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

| Name | Type | | ----------------------------------- | ----- | | @quri/squiggle-components | Patch | | @quri/versioned-squiggle-components | Patch | | vscode-squiggle | Patch | | @quri/squiggle-lang | Patch | | @quri/prettier-plugin-squiggle | Patch | | @quri/squiggle-textmate-grammar | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR