built-in overriden in "correctness -> else clause on loop without a break statement"

[CastixGitHub]

The list built-in is overridden Thanks for your beautiful work :)

[BrunoDesthuilliers]

in https://docs.quantifiedcode.com/python-anti-patterns/correctness/else_clause_on_loop_without_a_break_statement.html :

def contains_magic_number(list, magic_number):
    for i in list:

:-)

[CastixGitHub]

Talking about correctness, instead of break, I think return is more appropriate here

>>> def contains_magic_number(numbers, magic_number):
...     for n in numbers:
...             if magic_number == n:
...                     return True
...     else:
...             return False
... 
>>> print("This list contains the magic number."
...       if contains_magic_number(range(10), 5)
...       else "This list does NOT contain the magic number.")
This list contains the magic number

otherwise do not use a loop at all, use a list comprehension or filter() instead

>>> def contains_magic_number(numbers, magic_number):
...     if len([n for n in numbers if n == magic_number]) != 0:
...             print("This list contains the magic number.")
...     else:
...             print("This list does NOT contain the magic number.")
... 
>>> contains_magic_number(range(10), 5)
This list contains the magic number.

[Stigjb]

This seems to have been fixed in https://github.com/quantifiedcode/python-anti-patterns/commit/5f6e7bf7eff4b3516450e455fdf1c62447a3ea76, so the issue should probably be closed.

However, the website still shows the old version that redefines list.