search

quantifiedcode / python-anti-patterns

An open collection of Python anti-patterns and worst practices.
https://quantifiedcode.github.io/python-anti-patterns
Other
1.71k stars 249 forks source link

iteritems needs qualification #71

Closed tacaswell closed 9 years ago

tacaswell commented 9 years ago

http://docs.quantifiedcode.com/python-anti-patterns/performance/not_using_iteritems_to_iterate_large_dict.html

This needs a warning that this only applies to python 2 which is end-of-lifed.

vogelsgesang commented 9 years ago

And again, you are right. This best practice only applies to Python 2. Do you want to fix it or should I do it?

timofurrer commented 9 years ago

See #47