search

quantile-development / dagster-meltano

A Dagster plugin that allows you to run Meltano in Dagster
MIT License
41 stars 17 forks source link

feat: remove type annotation for context param in meltano_install op #41

Closed mgierada closed 9 months ago

mgierada commented 9 months ago

The OpExecutionContext type annotation in meltano_install is raising errors like that when running with dagster >=1.5.0

image

This is expected as 1.5.0 introduces some breaking changes in that area. See release notes:

When type hint is remove, dagster loads fine.

resulyrt93 commented 9 months ago

please review that PR

JulesHuisman commented 9 months ago

Published a new version!

resulyrt93 commented 9 months ago

I'm still getting that error, i suppose we should also remove that type annotation. Thus it worked in my local