Closed ReneTC closed 3 months ago
The version is set here: https://github.com/quantile-development/dagster-meltano/blob/f4410d24587540400b7cffcd012a4711e91c0a42/pyproject.toml#L14
But you can simply install a specific Dagster version in the same environment.
E.g. pip install dagster-meltano dagster==1.5.0
Thanks for the suggestion. I need to upgrade to get some new features out of Dagster. For the Meltano dagster -utilty it also install dagster-ext? I don't recall installing that manually so my meltano.yml looks like this:
- name: dagster
variant: quantile-development
pip_url: dagster-ex
config:
repository_dir: ${MELTANO_PROJECT_ROOT}/orchestrate
This gives me the versions I posted before. Trying to upgrade with your suggestion is:
- name: dagster
variant: quantile-development
pip_url: dagster-ex dagster==1.5.0
config:
repository_dir: ${MELTANO_PROJECT_ROOT}/orchestrate
But during install, this result in conflicts:
Utility 'dagster' could not be installed: failed to install plugin 'dagster'. ERROR: Cannot install dagster-ext, dagster-ext==0.1.0 and dagster==1.5.0 because these package versions have conflicting dependencies.
If you are able to dig up which packages are conflicting we can increase the range of those packages.
Thanks @JulesHuisman I've been trying to set the dagster-ex to have dagster at least 1.5.0. So far no luck, I'll updater if I find the conflict.
@JulesHuisman I think it has something to do with typer? I have been trying to use some kind of later version of Dagster 1.5 and I get the following logs
Which I think is set here: https://github.com/quantile-development/dagster-ext/blob/master/pyproject.toml and we need to update typer = "^0.6.1"
to be typer = "^0.9.0"
?
@JulesHuisman I think it has something to do with typer? I have been trying to use some kind of later version of Dagster 1.5 and I get the following logs
Which I think is set here: https://github.com/quantile-development/dagster-ext/blob/master/pyproject.toml and we need to update
typer = "^0.6.1"
to betyper = "^0.9.0"
?Logs
I think we can probably increase the range of the package even more. I don't have too much time right now to look into it. But I might be able to look at it later, or possibly accept a PR.
Hi @JulesHuisman ,
I did the following;
poetry build
on both repositories, and I think it built ok?
This is admittedly my first time trying to contribute to public repos, and I don't normally work in Python. I tried pushing my branches to the repos but I'm getting 403 errors because write access is restricted (reasonably so).
If the above looks ok would I be give write access to both dagster-ext and dagster-meltano to push my changes so you could accept a PR? This would also help with https://github.com/quantile-development/dagster-meltano/issues/48 I think.
Thank you!
Hi @JulesHuisman ,
I did the following;
- Cloned the dagster-meltano and dagster-ext repositories
- Updated on dagster-meltano to also be compatible with 3.12 (updated the test.yaml too)
![]()
- Updated dagster-ext to accept python 3.12 and also updated typer to ^0.9.0
- Used
poetry build
on both repositories, and I think it built ok?This is admittedly my first time trying to contribute to public repos, and I don't normally work in Python. I tried pushing my branches to the repos but I'm getting 403 errors because write access is restricted (reasonably so).
If the above looks ok would I be give write access to both dagster-ext and dagster-meltano to push my changes so you could accept a PR? This would also help with #48 I think.
Thank you!
You can create a fork on Github, and then create a PR to the original repo! That way I can review the changes there.
Hi Jules,
Please see the PRs here, thanks! https://github.com/quantile-development/dagster-ext/pull/11 https://github.com/quantile-development/dagster-meltano/pull/54
Thanks @joshua-janicas would be great to see this merged. I'd like to make use of some recent features in dagster-dbt with this change in place.
Giving another poke here to see if we can have the PRs looked at sometime soon! Thank you!
Deployed the new version, thanks @joshua-janicas!
Does anyone know where the dagster version is set? I am not sure, but it seems dagster is installed via this package. The versions are:
can we upgrade, or am i in the wrong place? edit// Or maybe it is here instead? https://github.com/quantile-development/dagster-ext